-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default to --check-level=exhaustive
internally / several related cleanups
#6225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Apr 3, 2024
@@ -851,6 +851,9 @@ class TestSimplifyUsing : public TestFixture { | |||
"}"; | |||
|
|||
ASSERT_EQUALS(exp, tok(code)); | |||
ASSERT_EQUALS("[test.cpp:7]: (debug) valueFlowConditionExpressions bailout: Skipping function due to incomplete variable NS1\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed https://trac.cppcheck.net/ticket/12583 about this.
firewave
force-pushed
the
exhaustive
branch
2 times, most recently
from
April 7, 2024 21:17
eae9641
to
ebca683
Compare
firewave
force-pushed
the
exhaustive
branch
2 times, most recently
from
April 11, 2024 08:05
85ccd86
to
1e5d69e
Compare
I flaked on some of the test fixes since there were so many messages to handle. We definitely need to clean this up more so the code doesn't produce the warnings and we no longer need to ignore stuff. |
danmar
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.